Airbnb·Software Engineer·Technical Phone Screen
- You're shown a code diff live. Walk through how you'd structure your review comments, including what categories you check, in what order, and how you'd label severity.
- Write out the actual text of a blocker comment, a suggestion, and a nit as you would type them on a real pull request.
- How do you handle reviewing a change when you don't have access to the ticket, the surrounding codebase, or the author to answer questions?
- The author pushes back on your blocker, saying the edge case you flagged can't actually happen in practice. How do you respond?
- You spot a deeper design problem that the diff exposes but didn't actually introduce. Do you raise it in the review, and if so, how do you scope it so the PR isn't blocked forever?
- How would your review approach differ for a junior engineer's first PR versus a staff engineer's change to a critical production service?
- The change has no tests but looks obviously correct. Do you block the PR on missing tests, and where do you draw that line?
“The order thing tripped me up a bit.”