Disney·Software Engineer·Technical Phone Screen
- You're given a working but poorly written React/TypeScript component from a junior engineer. Walk through the issues you'd flag in a code review, prioritized by impact across correctness, security, performance, accessibility, and maintainability.
- How would you frame your feedback to help the junior engineer actually learn from it, rather than just listing what's wrong?
- What concrete refactors would you suggest for the component, covering structure, state management, separation of concerns, naming, typing, and error handling?
- What tests would you add or request for this component, and what specific behaviors should they cover across unit, integration, and end-to-end levels?
- After the review is done, how do you follow up with the junior engineer to make sure the feedback sticks and similar issues don't keep showing up?
“This is where I spent the most time and honestly probably over-indexed on maintainability stuff early on when I should've led with correctness and security.”